Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add sessions for zenoh-c specific and shallow copy #56

Conversation

YuanYuYuan
Copy link
Contributor

No description provided.

Copy link

@milyin milyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but found one wrong piece in the code sample

printf("Received an error\n");
}
z_drop(z_move(reply));
z_sample_t sample = z_reply_ok(&reply);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be

const z_loaned_sample_t *sample = z_reply_ok(z_loan(reply));

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @milyin. I've updated it accordingly.

@Mallets Mallets merged commit f310281 into atolab:migration_v1.0.0 Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants