Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Migration guides to v1.0.0 #51

Merged
merged 52 commits into from
Sep 10, 2024
Merged

Add Migration guides to v1.0.0 #51

merged 52 commits into from
Sep 10, 2024

Conversation

Charles-Schleich
Copy link
Contributor

@Charles-Schleich Charles-Schleich commented Jul 18, 2024 •
edited
Loading

Add Migration guides To Zenoh

  • Zenoh concepts Migration Guide v1.0.0
  • Rust v1.0.0
  • Python v1.0.0
  • C / Pico v.1.0.0
  • C++ Migration guide
  • Kotlin v1.0.0
  • Java v1.0.0

@Mallets Mallets self-requested a review July 22, 2024 10:00
@Charles-Schleich
Mention attachment, minor rewrite Encoding, explain reply, RingChanne…
7dd2544 
…l similar, explain timestamps, separate plugin into own section.
J-Loudet
J-Loudet reviewed Jul 29, 2024
View reviewed changes
Copy link
Contributor

@J-Loudet J-Loudet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typos, missing punctuation, missing articles, sentences that needed rephrasing

content/docs/migration_1.0/C++.md Outdated Show resolved Hide resolved
content/docs/migration_1.0/C++.md Outdated Show resolved Hide resolved
content/docs/migration_1.0/C++.md Outdated Show resolved Hide resolved
content/docs/migration_1.0/C++.md Outdated Show resolved Hide resolved
content/docs/migration_1.0/C++.md Outdated Show resolved Hide resolved
content/docs/migration_1.0/Python.md Outdated Show resolved Hide resolved
content/docs/migration_1.0/Python.md Outdated Show resolved Hide resolved
content/docs/migration_1.0/Rust.md Outdated Show resolved Hide resolved
content/docs/migration_1.0/Rust.md Outdated Show resolved Hide resolved
content/docs/migration_1.0/Rust.md Outdated Show resolved Hide resolved
@Charles-Schleich @Mallets
Apply suggestions from code review
1262961 
Co-authored-by: Luca Cominardi <luca.cominardi@gmail.com>
Loic-kd
Loic-kd reviewed Sep 10, 2024
View reviewed changes
Copy link

@Loic-kd Loic-kd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Charles

content/docs/migration_1.0/Kotlin.md Outdated Show resolved Hide resolved
content/docs/migration_1.0/Kotlin.md Outdated Show resolved Hide resolved
content/docs/migration_1.0/Kotlin.md Outdated Show resolved Hide resolved
content/docs/migration_1.0/Kotlin.md Outdated Show resolved Hide resolved
content/docs/migration_1.0/Kotlin.md Outdated Show resolved Hide resolved
content/docs/migration_1.0/Kotlin.md Outdated Show resolved Hide resolved
Charles-Schleich
Charles-Schleich commented Sep 10, 2024
View reviewed changes
content/docs/migration_1.0/Kotlin.md Outdated Show resolved Hide resolved
content/docs/migration_1.0/Kotlin.md Outdated Show resolved Hide resolved
@Charles-Schleich Charles-Schleich merged commit b1a9624 into master Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Loic-kd Loic-kd Loic-kd left review comments

@DenisBiryukov91 DenisBiryukov91 DenisBiryukov91 left review comments

@J-Loudet J-Loudet J-Loudet requested changes

@imstevenpmwork imstevenpmwork imstevenpmwork left review comments

@jean-roland jean-roland jean-roland left review comments

@fuzzypixelz fuzzypixelz fuzzypixelz left review comments

@wyfo wyfo wyfo left review comments

@Mallets Mallets Mallets left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.