Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change internal representation of ID #14

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Change internal representation of ID #14

merged 1 commit into from
Mar 25, 2024

Conversation

Mallets
Copy link
Contributor

@Mallets Mallets commented Mar 25, 2024

Move from NonZeroU128 to [u8;16].

Pros:

  • Memory layout guarantees across platforms and compiler versions for FFI

Cons:

  • The usage of NonZeroU128 exploits compiler niche for Option<NonZeroU128>.

Linked PR: eclipse-zenoh/zenoh-c#295

This was referenced Mar 25, 2024
Merged
Merged
@Mallets Mallets added the enhancement New feature or request label Mar 25, 2024
@JEnoch JEnoch merged commit 874b7e4 into master Mar 25, 2024
4 checks passed
@Mallets Mallets deleted the zid branch March 25, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JEnoch JEnoch JEnoch approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mallets @JEnoch