Add NTP64::as_secs_f64() #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
NTP64::as_secs_f64()operation.This avoids going through
.to_system_time().duration_since(std::time::UNIX_EPOCH).unwrap().as_secs_f64(), also preventing approximations that made resultingf64not comparables.The decimal part of the f64 is the result of a division of NTP64's Fraction part by 2^32.
As a consequence, the even if resulting f64 seems to have a precision lower than 1 nanosecond, that's not the case. It still has the precision of the time source (3.5 nanosecond if generated by
HLC).