Skip to content

Commit

Permalink
Merge branch 'refactor-menu-resolvers-7.6' into refactor-menu-resolve…
Browse files Browse the repository at this point in the history
…rs-9.0
  • Loading branch information
YanaDePauw committed Feb 18, 2025
2 parents 0fec539 + 8b9af3b commit 174d185
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 9 deletions.
12 changes: 5 additions & 7 deletions src/app/shared/menu/menu.structure.spec.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { buildMenuStructure } from './menu.structure';
import { MenuID } from './menu-id.model';
import { MenuProviderService } from './menu-provider.service';
import { MenuRoute } from './menu-route.model';
import { AccessControlMenuProvider } from './providers/access-control.menu';
import { AdminSearchMenuProvider } from './providers/admin-search.menu';
Expand Down Expand Up @@ -101,18 +100,17 @@ describe('buildMenuStructure', () => {
];


it('should have a double amount of objects with an additional service after the processing', () => {
it('should have a double amount of objects after the processing', () => {
const result = buildMenuStructure(providerStructure);
expect(result.length).toEqual(orderedProviderTypeList.length * 2 + 1);
expect(result.length).toEqual(orderedProviderTypeList.length * 2);
});

it('should return a list with the MenuProviderService and then a resolved provider and provider type for each provider in the provided structure', () => {
it('should return a list with a resolved provider and provider type for each provider in the provided structure', () => {
const result = buildMenuStructure(providerStructure);
expect(result[0]).toEqual(MenuProviderService);

orderedProviderTypeList.forEach((provider, index) => {
expect((result[(index + 1) * 2 - 1] as any).deps).toEqual([provider]);
expect(result[(index + 1) * 2]).toEqual(provider);
expect((result[index * 2] as any).deps).toEqual([provider]);
expect(result[index * 2 + 1]).toEqual(provider);
});
});
});
2 changes: 0 additions & 2 deletions src/app/shared/menu/menu.structure.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import {
AbstractMenuProvider,
MenuProviderTypeWithOptions,
} from './menu-provider.model';
import { MenuProviderService } from './menu-provider.service';
import { MenuRoute } from './menu-route.model';

export const MENU_PROVIDER = new InjectionToken<AbstractMenuProvider>('MENU_PROVIDER');
Expand All @@ -35,7 +34,6 @@ type MenuStructure = {
*/
export function buildMenuStructure(structure: MenuStructure): Provider[] {
const providers: Provider[] = [
MenuProviderService,
];

Object.entries(structure).forEach(([menuID, providerTypes]) => {
Expand Down

0 comments on commit 174d185

Please sign in to comment.