feedback

atlv24 · Jan 11, 2025 · e1a6713 · e1a6713
1 parent 0fbac57
commit e1a6713
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/naga/src/front/glsl/parser/types.rs b/naga/src/front/glsl/parser/types.rs
@@ -274,9 +274,19 @@ impl ParsingContext<'_> {
                     qualifiers.precision = Some((p, token.meta));
                 }
                 TokenValue::MemoryQualifier(access) => {
+                    let load_store = crate::StorageAccess::LOAD | crate::StorageAccess::STORE;
                     let storage_access = qualifiers
                         .storage_access
-                        .get_or_insert((crate::StorageAccess::all(), Span::default()));
+                        .get_or_insert((load_store, Span::default()));
+
+                    if !storage_access.0.contains(!access & load_store) {
+                        frontend.errors.push(Error {
+                            kind: ErrorKind::SemanticError(
+                                "The same memory qualifier can only be used once".into(),
+                            ),
+                            meta: token.meta,
+                        })
+                    }
 
                     storage_access.0 &= access;
                     storage_access.1.subsume(token.meta);

diff --git a/naga/tests/in/atomicTexture.param.ron b/naga/tests/in/atomicTexture.param.ron
@@ -5,7 +5,7 @@
 		capabilities: [],
 	),
 	hlsl: (
-		shader_model: V6_6,
+		shader_model: V5_0,
 		binding_map: {},
 		fake_missing_bindings: true,
 		special_constants_binding: Some((space: 1, register: 0)),