Translate JFR stacktrace symbols #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagguh
force-pushed
the
translate-jfr-stacktrace-symbols
branch
from
ec12c6f to
749605f
Compare
Before - split in flamegraph when compared 2 files having in fact the same stack traces
After - no split in flamegraph
|
mgrzaslewicz
previously approved these changes
Jul 1, 2024
dagguh
force-pushed
the
translate-jfr-stacktrace-symbols
branch
from
ca9d5ce to
26d975f
Compare
mgrzaslewicz
approved these changes
Jul 1, 2024
mgrzaslewicz
previously approved these changes
Jul 1, 2024
Naming the byte array as an explicit type gives us: - one Javadoc to explain the contents - memoized `new String(bytes)` Also clean up dead code and add missing changelog.
The forced loop-reading was inherited from JMC, but we don't know its purpose. The simpler one-shot impl passes our tests and the output JFR opens in IntelliJ. PS. remove unncessary ByteArray clone.
dagguh
force-pushed
the
translate-jfr-stacktrace-symbols
branch
from
26d975f to
e36389d
Compare
mgrzaslewicz
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Result so far:
