Arc 1556 safe guard on subscription find x #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gxueatlassian
commented
Jul 29, 2022
mboudreau
reviewed
Aug 1, 2022
mboudreau
reviewed
Aug 1, 2022
mboudreau
reviewed
Aug 1, 2022
mboudreau
reviewed
Aug 1, 2022
mboudreau
reviewed
Aug 1, 2022
mboudreau
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Adding safe guard to the
Subscriptionsmodel, ( and accidentally add support forgitHubAppIdas well)Why
If
GHEaccidentally turned on, the safe guard ofgitHubAppId is nullto protect data from messing up betweencloudandserver.Added feature flags
N/A
Affected issues
https://softwareteams.atlassian.net/browse/ARC-1556
How has this been tested?
Unit test.
Stage: Tested
Whats Next?
Refer to linked issue under ticket https://softwareteams.atlassian.net/browse/ARC-1480