Add measurement of React tree size #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 22, 2020 16:39
This doesn't feel right but I'm finding it hard to type this properly.
alexreardon
reviewed
Jun 24, 2020
alexreardon
requested changes
Jun 24, 2020
alexreardon
requested changes
Jun 25, 2020
|
I’m keen to get this in 😍 |
alexreardon
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new static task to measure the React tree size.
In React 16^, the virtual DOM consists of both React elements and internal objects called “fibers” to hold additional information about the component tree. This task currently treats all of these the same and returns a count of all of all of them.
I'm sure there are some improvements that could be made to the TypeScript pieces of the code here, I'm not super experienced with TS and felt very uncomfortable with the piece extending the
HTMLElementtype, but otherwise the_reactRootContainerproperty couldn't be accessed. I'm sure there is a better way!