Get Slack token from file instead of environment variable #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise get it from env var
vcatlassian
requested review from
Jacobious52,
vincentportella,
MinyiZ,
hligit,
dtnyn and
hyang200
awprice
previously approved these changes
Nov 27, 2023
vcatlassian
force-pushed
the
allow-secrets-from-file
branch
from
83118a7 to
4c476f4
Compare
hligit
approved these changes
Nov 27, 2023
Jacobious52
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following Kubernetes security best practice (https://www.tenable.com/audits/items/CIS_Kubernetes_v1.6.1_Level_2_Master.audit:98de3da69271994afb6211cf86ae4c6b), try to get Slack token from file first, only when the file name is not set, fall back to load token from environment variable directly. Also added unit tests and updated doc.
Closes #71.