fix the order of nested for loop #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcatlassian
force-pushed
the
vchen2/fix-for-loop-in-getNodesToTerminate
branch
from
e1b0ae8 to
8eedb0a
Compare
vcatlassian
force-pushed
the
vchen2/fix-for-loop-in-getNodesToTerminate
branch
from
8eedb0a to
2bb79a4
Compare
dtnyn
approved these changes
Jun 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order of the 2 nested
forloop could potentially makenumNodesInProgress++getting executed for more than once - this won't cause issue when concurrency is 1. Changed the order so that it will loop all ready nodes first.Also removed
reapedChildrenfrompkg/controller/cyclenoderequest/transitioner/util.gowhich is not used.Upgraded github action versions - old versions are deprecated and caused lint job failed.