Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cordon node before performing pre-termination checks #50

Merged
merged 3 commits into from
Aug 15, 2022

Conversation

MinyiZ
Copy link
Collaborator

@MinyiZ MinyiZ commented Aug 10, 2022

  • Perform pre-termination checks after cordoning a node instead of before.
  • bump linter version and fix minor linter error

Tested in lab 👍

@MinyiZ MinyiZ force-pushed the mzhong/swap-pre-terminating-check-order branch from 4d0926d to 13cb07d Compare August 11, 2022 01:07
@MinyiZ MinyiZ requested a review from mwhittington21 August 11, 2022 01:19
Copy link
Collaborator

@Jacobious52 Jacobious52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 💯

@MinyiZ MinyiZ merged commit 251868c into master Aug 15, 2022
@MinyiZ MinyiZ deleted the mzhong/swap-pre-terminating-check-order branch August 15, 2022 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants