Skip to content

Commit

Permalink
Merge pull request #68 from atlassian-labs/vportella/improve-failed-h…
Browse files Browse the repository at this point in the history
…ealthcheck-error-logging

Add logging for the error returned when a health check does not pass
  • Loading branch information
vincentportella authored Sep 28, 2023
2 parents 5889485 + fa046b9 commit 48ed956
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions pkg/controller/cyclenoderequest/transitioner/checks.go
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ func (t *CycleNodeRequestTransitioner) performHealthCheck(node v1.CycleNodeReque

// Still within the waiting period here, must trigger requeueing this phase
if err := healthCheckPassed(healthCheck, statusCode, body); err != nil {
t.rm.Logger.Error(err, "Health check did not pass", "endpoint", endpoint, "error", err)
return true, fmt.Errorf("health check did not pass for the endpoint %s, got: (%d) %s", endpoint, statusCode, string(body))
}

Expand Down

0 comments on commit 48ed956

Please sign in to comment.