chore: upgrades minor and patch deps #420
Conversation
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "typescript.tsdk": "node_modules/typescript/lib" | |||
There was a problem hiding this comment.
Nice, we configured it here. I had similar one in my user settings.
| @@ -31,14 +31,14 @@ | |||
| "version-nightly": "bash scripts/should-nightly-run.sh && npm version prerelease --no-git-tag-version --preid=$(git rev-parse HEAD)", | |||
| "postversion": "bash scripts/push-if-git.sh", | |||
| "bundlesize": "yarn build && yarn build:dead-code-elimination && size-limit", | |||
| "postinstall": "npx yarn-deduplicate" | |||
| "postinstall": "npx yarn-deduplicate && yarn --ignore-scripts" | |||
There was a problem hiding this comment.
Are we ignoring postinstall script for dependencies? Any specific reason? 🤔
There was a problem hiding this comment.
only for postinstall - this is to stabalize the yarn lock after de-duping (and so it doesnt result in an infinite loop)
unfortunately there can be instances where running yarn after yarn de-dupe will result in the yarn lock file updating again
| t.variableDeclaration('const', [t.variableDeclarator(sheetIdentifier, t.stringLiteral(sheet))]) | ||
| ); | ||
| const parent = meta.parentPath.findParent((path) => path.isProgram()); | ||
| const parentBody = parent && (parent.get('body') as NodePath[]); |
There was a problem hiding this comment.
So all of these started breaking just after patch/minor bump ups? 😨
| @@ -21,11 +23,14 @@ export const getImportDeclarationCollection = ({ | |||
| j: JSCodeshift; | |||
| collection: Collection<any>; | |||
| importPath: string; | |||
| }) => | |||
| collection | |||
| }): Collection<ImportDeclaration> => { | |||
There was a problem hiding this comment.
Love explicit typings over implicit one. TS compiler will be fast if we specify return types.
There was a problem hiding this comment.
we could add an eslint rule for that too.
There was a problem hiding this comment.
Maybe later. Should we add card for this? Because it might require changes too.
itsdouges
force-pushed
the
upgrade-deps
branch
from
86702fd to
5562175
Compare
This actually shows the type errors we saw when doing your interpolation changes @pgmanutd.
This is a pre-req for the
runtime: automaticjsx fix.