chore: remove commonjs bundle split points #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgmanutd
reviewed
Dec 19, 2020
| @@ -96,7 +96,7 @@ | |||
| }, | |||
| { | |||
| "path": "./packages/react/dist/browser/runtime.js", | |||
| "limit": "489B", | |||
| "limit": "445B", | |||
pgmanutd
reviewed
Dec 19, 2020
| color: blue; | ||
| border: 1px solid black; | ||
| `; | ||
| // It's notoriously hard to do both server and client rendering in this test. |
pgmanutd
reviewed
Dec 19, 2020
| */ | ||
| const StyleCacheProvider: ProviderComponent = (props) => { | ||
| if (isNodeEnvironment()) { | ||
| // This code path isn't conditionally called at build time - safe to ignore. |
There was a problem hiding this comment.
nit: 🤔 It will work we know. Just wondering won't it confuse developers who are so familiar with rules of hooks? Is there a way we can split it into two components like we did before and do something like:
const StyleCacheProvider = isNodeEnvironment() ? StyleServerCacheProvider: StyleClientCacheProvider;or maybe
const StyleCacheProvider: ProviderComponent = (props) => {
if (isNodeEnvironment()) {
return <StyleServerCacheProvider {...props} />
}
return <StyleClientCacheProvider {...props} />
}Its still difficult to do as above for useCache though 😞
There was a problem hiding this comment.
this keeps the bundlesize down and keeps the react tree as small as possible - i wouldn't want to make more TBH
pros & cons - in this instance having good amounts of comments should work - i'll update them a bit though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the two browser/main bundles into one to remove the
requirecall in the code - enabling strict mode modules to function correctly.Interestingly this also reduces the bundle size slightly.
Closes #405