Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

197 fix styled expressions #198

Merged
merged 3 commits into from
May 26, 2020
Merged

197 fix styled expressions #198

merged 3 commits into from
May 26, 2020

Conversation

itsdouges
Copy link
Collaborator

@itsdouges itsdouges commented May 25, 2020

Fixes #197

root.each(node => {
(opts) => {
return (root) => {
root.each((node) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done with the shorthand expressions i see 😝

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh i think prettier did it

@@ -190,6 +183,7 @@ export const templateLiteralToCss = (
const result = evaluateFunction(declarationNode, collectedDeclarations, context);
css += result.css;
cssVariables = cssVariables.concat(result.cssVariables);
// TODO: DOUBLE CHECK THIS NEEDS PREFIX EXTRACTION ^
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these intentional?

Copy link
Collaborator Author

@itsdouges itsdouges May 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah need to test first

danieldelcore
danieldelcore previously approved these changes May 26, 2020
Copy link
Collaborator

@danieldelcore danieldelcore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@danieldelcore danieldelcore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smashed it!

@itsdouges itsdouges merged commit a111158 into master May 26, 2020
@itsdouges itsdouges deleted the 197-fix-styled-expressions branch May 26, 2020 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interpolation in styled template literal doesn't support values or expressions
2 participants