-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
197 fix styled expressions #198
Conversation
root.each(node => { | ||
(opts) => { | ||
return (root) => { | ||
root.each((node) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done with the shorthand expressions i see 😝
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh i think prettier did it
@@ -190,6 +183,7 @@ export const templateLiteralToCss = ( | |||
const result = evaluateFunction(declarationNode, collectedDeclarations, context); | |||
css += result.css; | |||
cssVariables = cssVariables.concat(result.cssVariables); | |||
// TODO: DOUBLE CHECK THIS NEEDS PREFIX EXTRACTION ^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah need to test first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smashed it!
Fixes #197