DCPERF-747 Allow overriding the resource_owner label
#27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacek-foremski
requested review from
mgrzaslewicz,
mzyromski-atlassian,
pczuj and
jreczyckiatatlassian
pczuj
reviewed
Nov 21, 2024
| */ | ||
| data class Investment( | ||
| private val useCase: String, | ||
| val lifespan: Duration, | ||
| private val disposable: Boolean = true, | ||
| val reuseKey: () -> String = { "jpt-${UUID.randomUUID()}" } | ||
| val reuseKey: () -> String = { "jpt-${UUID.randomUUID()}" }, | ||
| private val resourceOwner: String = "jforemski" |
There was a problem hiding this comment.
This class needs builder. I believe the change doubles the constructors count from 4 to 8 and all of them are part of lib's API.
jacek-foremski
force-pushed
the
issue/DCPERF-747-change-aws-service-owners
branch
from
22c2ef4 to
c336a84
Compare
jreczyckiatatlassian
approved these changes
Nov 22, 2024
mgrzaslewicz
approved these changes
Nov 22, 2024
jacek-foremski
deleted the
issue/DCPERF-747-change-aws-service-owners
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows clients to override the
resource_ownertag.It also changes the default
resource_ownertag to the current Atlassian JPT maintainer, yours truly