Bump Ubuntu Focal #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagguh
commented
Jun 10, 2024
CHANGELOG.md
Outdated
| - Add `CanonicalAmiProvider.Builder.avoidUnattendedUpgrades` for bumping `imageName` to Focal or higher. | ||
|
|
||
| ### Fixed | ||
| - Unpin Ubuntu Focal version in `CanonicalAmiProvider.Builder` by default. |
There was a problem hiding this comment.
Controversial, because it goes against repeatable builds (our Robustness value).
OTOH our first value is Meaningfulness and I bet our users do update their Ubuntus all the time (no evidence for the claim tho).
There was a problem hiding this comment.
We could rethink the approach if the less-repeatable builds around Ubuntu build would ever bite us. If we can easily switch back to the fixed build I think we are good to go.
pczuj
reviewed
Jun 10, 2024
CHANGELOG.md
Outdated
|
|
||
| ### Fixed | ||
| - Unpin Ubuntu Focal version in `CanonicalAmiProvider.Builder` by default. | ||
| You can still pin a specific release date, e.g. `imageName("ubuntu/images/hvm-ssd/ubuntu-focal-20.04-amd64-server-20240531")` |
pczuj
previously approved these changes
Jun 10, 2024
mgrzaslewicz
previously approved these changes
Jun 10, 2024
This reverts commit b5a272e. The DescribeRequest via Java SDK the filter didn't work like "contains", but as "equals". Weird, because via GUI it always works like "contains". And on HTTP level the requests look almost identical (hostname is different). Anyway, we're back to a pinned (and bumped) version.
mgrzaslewicz
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.