Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a command to delete the cache #3581

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shamazmazum
Copy link
Contributor

Description

This PR adds a command clear-cache for cache deletion.

Checklist:

  • Git branch state is mergable.
  • Changelog is up to date (via a separate commit).
  • New dependencies are accounted for.
  • Documentation is up to date.
  • Compilation and tests ((asdf:test-system :nyxt/<renderer>))
    • No new compilation warnings.
    • Tests are sufficient.

@aadcg
Copy link
Member

aadcg commented Jan 23, 2025

@shamazmazum I'd rather not merge these kind of changes until the ffi method is also specialized for Electron.

If I change my mind, the absolute minimum requirement would be for the command to raise a warning when *renderer* is Electron since it is a no-op.

@shamazmazum
Copy link
Contributor Author

No problem! Doesn't electron allow applications to control their cache?

Tried to use it on FreeBSD, but JS part seems to be too Linux-specific :)

@aadcg
Copy link
Member

aadcg commented Jan 23, 2025

No problem! Doesn't electron allow applications to control their cache?

It sure does, see https://www.electronjs.org/docs/latest/api/session#sesclearcache.

It would need to be added to cl-electron first, and then to Nyxt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants