Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review bookmarks panel UI #3444

Merged
merged 4 commits into from
Aug 1, 2024
Merged

Review bookmarks panel UI #3444

merged 4 commits into from
Aug 1, 2024

Conversation

aadcg
Copy link
Member

@aadcg aadcg commented Aug 1, 2024 •
edited
Loading

Description

Fixes #3433

Checklist:

  • Git branch state is mergable.
  • Changelog is up to date (via a separate commit).
  • New dependencies are accounted for.
  • Documentation is up to date.
  • Compilation and tests ((asdf:test-system :nyxt/<renderer>))
    • No new compilation warnings.
    • Tests are sufficient.

@aadcg
Copy link
Member Author

aadcg commented Aug 1, 2024

@shamazmazum These changes should address your concerns.

@aadcg aadcg merged commit c2fc423 into master Aug 1, 2024
0 of 3 checks passed
@aadcg aadcg deleted the review-bookmarks-panel-ui branch August 1, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bookmarks panel UX is terrible
1 participant
@aadcg