Fix nasdf

[aadcg]

Description

Fixes #2981

Checklist:

Everything in this checklist is required for each PR. Please do not approve a PR that does not have all of these items.

• Git hygiene:
  • I have pulled from master before submitting this PR
  • There are no merge conflicts.
• I've added the new dependencies as:
  • ASDF dependencies,
  • Git submodules,

    cd /path/to/nyxt/checkout
    git submodule add https://gitlab.common-lisp.net/nyxt/py-configparser _build/py-configparser

  • and Guix dependencies.
• My code follows the style guidelines for Common Lisp code. See:
  • Norvig & Pitman's Tutorial on Good Lisp Programming Style (PDF)
  • Google Common Lisp Style Guide
• I have performed a self-review of my own code.
• My code has been reviewed by at least one peer. (The peer review to approve a PR counts. The reviewer must download and test the code.)
• Documentation:
  • All my code has docstrings and :documentations written in the aforementioned style. (It's OK to skip the docstring for really trivial parts.)
  • I have updated the existing documentation to match my changes.
  • I have commented my code in hard-to-understand areas.
  • I have updated the changelog.lisp with my changes if it's anything user-facing (new features, important bug fix, compatibility breakage).
    • Changelog update should be a separate commit.
  • I have added a migration.lisp entry for all compatibility-breaking changes.
  • (If this changes something about the features showcased on Nyxt website) I have these changes described in the new/existing article at Nyxt website or will notify one of maintainters to do so.
• Compilation and tests:
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works. (If possible.)
  • I ran the tests locally ((asdf:test-system :nyxt) and (asdf:test-system :nyxt/gi-gtk)) and they pass.

[aadcg]

Can only be merged once the following patch is accepted by Guix, https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67524.

[aartaka]

Looks good to me. Untested due to build failures. Minor comments:

• The changes regarding the renderer system go beyond the (I suppose) purpose of the PR—removing NASDF dependency from the submodules/libraries/etc.
• Same goes for keymap and make-instance checking—these are nor related to NASDF, are they?
• It's funny that you call NASDF-deleting PRs "fix" 😃

[jmercouris]

Finally.

[jmercouris]

Thank you for getting rid of the matrix of tests. This is a very welcome change. I see a lot of removed lines.

[jmercouris]

Well rather simplifying the matrix, to the platforms that matter for our purposes, currently.

[aadcg]

• The changes regarding the renderer system go beyond the (I suppose) purpose of the PR—removing NASDF dependency from the submodules/libraries/etc.

I believe you're referring to nyxt-renderer-system and *nyxt-renderer*. The goal of this PR is to revert the state of the affairs with regards to NASDF as it was before PR #2709 (namely reverting commit 8da7313).

• Same goes for keymap and make-instance checking—these are nor related to NASDF, are they?

I've considered that too. I'll move it to a different PR.

[aadcg]

Thank you for getting rid of the matrix of tests. This is a very welcome change. I see a lot of removed lines.

I've moved that work to #3268.