Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mode/bookmarks: Improve bookmarks panel #3204

Closed

Conversation

shamazmazum
Copy link
Contributor

This PR groups bookmarks by tags like list-bookmarks does.
20231007_07h27m25s_grim

Copy link
Member

@aadcg aadcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shamazmazum. I've left me minor comments.

source/mode/bookmark.lisp Outdated Show resolved Hide resolved
source/mode/bookmark.lisp Outdated Show resolved Hide resolved
@shamazmazum
Copy link
Contributor Author

@aadcg Thanks for your comments. I've updated my PR.

Now bookmarks are grouped by tags.
@aadcg aadcg mentioned this pull request Oct 9, 2023
2 tasks
@aadcg
Copy link
Member

aadcg commented Oct 9, 2023

@shamazmazum thanks for your work. I have doubts about how the UI should look like so I've opened the discussion in #3207. Notice that your commit has been preserved.

@aadcg aadcg closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants