Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add extraction from S3 for Snowflake Miner #91

Merged
merged 4 commits into from
Feb 25, 2025
Merged

feat: Add extraction from S3 for Snowflake Miner #91

merged 4 commits into from
Feb 25, 2025

Conversation

0xquark
Copy link
Contributor

@0xquark 0xquark commented Feb 25, 2025 •
edited
Loading

Description

  • Adds extraction logic from s3 for snowflake miner
  • Handles arbitrary permission error while removing a user

Related Issue

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes (if applicable)
  • I have updated documentation (if applicable)
  • All the checks and tests are passing locally
  • I have verified that the changes works as expected

Further Comments

@0xquark
feat: Add extraction from s3 in snowflake miner
60b6f45 
Signed-off-by: Karanjot Singh <drquark@duck.com>
@0xquark
fix: Handle permission error for remove-users endpoint
6e5a7d2 
Signed-off-by: Karanjot Singh <drquark@duck.com>
@0xquark 0xquark self-assigned this Feb 25, 2025
@0xquark 0xquark added the feature Adding this label to PR will put it in Feature section in Github Release Changelog label Feb 25, 2025
@0xquark
chore: Remove blank space and lint
3cdd204 
Signed-off-by: Karanjot Singh <drquark@duck.com>
Aryamanz29
Aryamanz29 approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@Aryamanz29 Aryamanz29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Aryamanz29
Aryamanz29 approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@Aryamanz29 Aryamanz29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small doubt here:

@0xquark @Aryamanz29
fix: Check if both conditions match for error
7f6d3ec 
Co-authored-by: Aryaman <56113566+Aryamanz29@users.noreply.github.com>
@0xquark 0xquark merged commit f3ffd5f into main Feb 25, 2025
5 checks passed
@0xquark 0xquark deleted the Snowflake-miner-s3 branch February 25, 2025 17:47
@0xquark 0xquark mentioned this pull request Feb 26, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aryamanz29 Aryamanz29 Aryamanz29 approved these changes

Assignees

@0xquark 0xquark

Labels
feature Adding this label to PR will put it in Feature section in Github Release Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xquark @Aryamanz29