Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP-5271 : Add support for removing users #90

Merged
merged 2 commits into from
Feb 19, 2025
Merged

APP-5271 : Add support for removing users #90

merged 2 commits into from
Feb 19, 2025

Conversation

0xquark
Copy link
Contributor

@0xquark 0xquark commented Feb 19, 2025

Description

This PR adds support for removing users through sdk.

Related Issue

APP-5271

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes (if applicable)
  • I have updated documentation (if applicable)
  • All the checks and tests are passing locally
  • I have verified that the changes works as expected

Further Comments

User needs to be enabled for removing and it takes few mins for a user to get removed.

Signed-off-by: Karanjot Singh <drquark@duck.com>
@0xquark 0xquark added the feature Adding this label to PR will put it in Feature section in Github Release Changelog label Feb 19, 2025
@0xquark 0xquark self-assigned this Feb 19, 2025
@0xquark 0xquark marked this pull request as ready for review February 19, 2025 00:38
Signed-off-by: Karanjot Singh <drquark@duck.com>
@Aryamanz29 Aryamanz29 self-requested a review February 19, 2025 06:15
Copy link
Member

@Aryamanz29 Aryamanz29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@0xquark 0xquark merged commit 4eed4cf into main Feb 19, 2025
5 checks passed
@0xquark 0xquark mentioned this pull request Feb 26, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding this label to PR will put it in Feature section in Github Release Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants