-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APP-5188 : Manage Workflows and Workflows Schedules | Support for Snowflake Miner with Abstract Package #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karanjot Singh <drquark@duck.com>
Signed-off-by: Karanjot Singh <drquark@duck.com>
…nd updating workflows Signed-off-by: Karanjot Singh <drquark@duck.com>
Signed-off-by: Karanjot Singh <drquark@duck.com>
|
Signed-off-by: Karanjot Singh <drquark@duck.com>
Signed-off-by: Karanjot Singh <drquark@duck.com>
…dding, Removing schedules Signed-off-by: Karanjot Singh <drquark@duck.com>
Signed-off-by: Karanjot Singh <drquark@duck.com>
…tom packages Signed-off-by: Karanjot Singh <drquark@duck.com>
Signed-off-by: Karanjot Singh <drquark@duck.com>
Signed-off-by: Karanjot Singh <drquark@duck.com>
Signed-off-by: Karanjot Singh <drquark@duck.com>
…hing) Signed-off-by: Karanjot Singh <drquark@duck.com>
Signed-off-by: Karanjot Singh <drquark@duck.com>
Signed-off-by: Karanjot Singh <drquark@duck.com>
…rray ([]) Signed-off-by: Karanjot Singh <drquark@duck.com>
Signed-off-by: Karanjot Singh <drquark@duck.com>
… err with no workflows found Signed-off-by: Karanjot Singh <drquark@duck.com>
Signed-off-by: Karanjot Singh <drquark@duck.com>
Signed-off-by: Karanjot Singh <drquark@duck.com>
Aryamanz29
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Signed-off-by: Karanjot Singh <drquark@duck.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces functionality for handling workflows and workflows schedules, including features to retrieve, create, remove, and update workflows and workflow schedules. It also adds a abstract package and abstract miner setup that can be extended later to support more packages or miners. Also, This PR includes support for the
Snowflake
Miner and Running workflows through JSON.Related Issue
APP-5188
Checklist
Further Comments
TBD - Integration tests will be added once the SDK supports creating connections. I have tested the methods manually (see main.go). For further testing of workflows in the integration tests, we need to create a test connection.