Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP-5188 : Manage Workflows and Workflows Schedules | Support for Snowflake Miner with Abstract Package #88

Merged
merged 21 commits into from
Feb 18, 2025

Conversation

0xquark
Copy link
Contributor

@0xquark 0xquark commented Feb 13, 2025

Description

This PR introduces functionality for handling workflows and workflows schedules, including features to retrieve, create, remove, and update workflows and workflow schedules. It also adds a abstract package and abstract miner setup that can be extended later to support more packages or miners. Also, This PR includes support for the Snowflake Miner and Running workflows through JSON.

Related Issue

APP-5188

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes (if applicable)
  • I have updated documentation (if applicable)
  • All the checks and tests are passing locally
  • I have verified that the changes works as expected

Further Comments

TBD - Integration tests will be added once the SDK supports creating connections. I have tested the methods manually (see main.go). For further testing of workflows in the integration tests, we need to create a test connection.

Signed-off-by: Karanjot Singh <drquark@duck.com>
Signed-off-by: Karanjot Singh <drquark@duck.com>
…nd updating workflows

Signed-off-by: Karanjot Singh <drquark@duck.com>
Signed-off-by: Karanjot Singh <drquark@duck.com>
@0xquark
Copy link
Contributor Author

0xquark commented Feb 13, 2025

pre-commit is acting up locally while running golangci-lint, showing unrelated errors and not running the linters correctly.

Signed-off-by: Karanjot Singh <drquark@duck.com>
Signed-off-by: Karanjot Singh <drquark@duck.com>
…dding, Removing schedules

Signed-off-by: Karanjot Singh <drquark@duck.com>
Signed-off-by: Karanjot Singh <drquark@duck.com>
…tom packages

Signed-off-by: Karanjot Singh <drquark@duck.com>
Signed-off-by: Karanjot Singh <drquark@duck.com>
Signed-off-by: Karanjot Singh <drquark@duck.com>
Signed-off-by: Karanjot Singh <drquark@duck.com>
…hing)

Signed-off-by: Karanjot Singh <drquark@duck.com>
Signed-off-by: Karanjot Singh <drquark@duck.com>
Signed-off-by: Karanjot Singh <drquark@duck.com>
…rray ([])

Signed-off-by: Karanjot Singh <drquark@duck.com>
Signed-off-by: Karanjot Singh <drquark@duck.com>
… err with no workflows found

Signed-off-by: Karanjot Singh <drquark@duck.com>
@0xquark 0xquark marked this pull request as ready for review February 17, 2025 22:06
@0xquark 0xquark self-assigned this Feb 17, 2025
@0xquark 0xquark added the feature Adding this label to PR will put it in Feature section in Github Release Changelog label Feb 17, 2025
Signed-off-by: Karanjot Singh <drquark@duck.com>
Signed-off-by: Karanjot Singh <drquark@duck.com>
@0xquark 0xquark changed the title APP-5188 : Manage Workflows and Workflows Schedules APP-5188 : Manage Workflows and Workflows Schedules | Support for Snowflake Miner with Abstract Package Feb 17, 2025
@Aryamanz29 Aryamanz29 self-requested a review February 18, 2025 16:48
Copy link
Member

@Aryamanz29 Aryamanz29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Signed-off-by: Karanjot Singh <drquark@duck.com>
@0xquark 0xquark merged commit 04e8e32 into main Feb 18, 2025
5 checks passed
@0xquark 0xquark deleted the APP-5188 branch February 18, 2025 18:22
@0xquark 0xquark mentioned this pull request Feb 26, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding this label to PR will put it in Feature section in Github Release Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants