Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

fix EOL #54

Merged
merged 1 commit into from
Apr 28, 2020
Merged

fix EOL #54

merged 1 commit into from
Apr 28, 2020

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Apr 28, 2020

@DarkSide666 Can we deduplicate "40...100" and is threshold really in % while the other values are not?

@mvorisek mvorisek marked this pull request as draft April 28, 2020 13:52
@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #54 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #54   +/-   ##
==========================================
  Coverage      61.87%   61.87%           
  Complexity       157      157           
==========================================
  Files              6        6           
  Lines            362      362           
==========================================
  Hits             224      224           
  Misses           138      138           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec9ed1e...2900877. Read the comment docs.

@DarkSide666
Copy link
Member

Not sure, but at least this way it works.
My guess is that one range if for codecov web interface to decide what color (red, yellow, green) to show and another range is for api.

Merging this in.

@DarkSide666 DarkSide666 marked this pull request as ready for review April 28, 2020 17:57
@DarkSide666 DarkSide666 self-requested a review April 28, 2020 17:57
@DarkSide666 DarkSide666 merged commit 3866915 into develop Apr 28, 2020
@DarkSide666 DarkSide666 deleted the fix_codecov_eol branch April 28, 2020 17:57
@mvorisek
Copy link
Member Author

@DarkSide666 and the percents?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants