First steps for compatibility with atk4/data:2.0.3 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In atk4/data:2.0.3 type hints where introduced in the functions in Field. This type hints need to be introduced in all the dependend modules. Just to get my application working again I introduced this change into the Password.php
Codecov Report
@@ Coverage Diff @@
## develop #35 +/- ##
=========================================
Coverage 6.35% 6.35%
Complexity 184 184
=========================================
Files 18 18
Lines 472 472
=========================================
Hits 30 30
Misses 442 442
Continue to review full report at Codecov.
|
|
@karakal from the description it seems there are more than this that needs fixing. Could you tell us what else needs updating? |
|
Possibly all the functions in there. I will have a look into it tonight and
submit a fix if necessary....
Romans Malinovskis <notifications@github.com> schrieb am Do., 9. Apr. 2020,
15:18:
… @karakal <https://github.com/karakal> from the description it seems there
are more than this that needs fixing. Could you tell us what else needs
updating?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#35 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AASVXJIUMIGDYXBJ35ZHJE3RLXDJ7ANCNFSM4MEFZ3VA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In atk4/data:2.0.3 type hints where introduced in the functions in Field. This type hints need to be introduced in all the dependend modules.
Just to get my application working again I introduced this change into the Password.php