-
Notifications
You must be signed in to change notification settings - Fork 23
[refactor] introduce debug classes under new structure #213
Conversation
b847995
to
ca0f370
Compare
4376ae7
to
7d05954
Compare
src/Connection_Counter.php
Outdated
@@ -4,101 +4,9 @@ | |||
|
|||
namespace atk4\dsql; | |||
|
|||
class Connection_Counter extends Connection_Proxy | |||
/** | |||
* @deprecated will be removed in v2.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose to write here: "will be removed in 2020-dec"
It is much easier for users to know when it will be removed and when to remove it in the code.
(update in everywhere)
Seems ok to merge except one thing - Driver vs. Connection. Why is driver really that much better? Driver is usually used for Even if really needed, I propose to keep @georgehristov ok with you? |
782dfd1
to
a7b392b
Compare
Then feel free to rename NS of other engines. But please, do not copy from old PR, only minimalistic rename, I will check (still have to compare manually because of old classes are not removed completely so git does handle this as renames). |
I would keep this PR only for the Debug connections. |
@mvorisek done so pls approve for the record. I will not merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pure NS updates/renames are done well. Approving rename of Debug Connections. No unresolved feedback left.
Please rename freshly (do not reuse anything from changed code from your huge PR) other engines.
@georgehristov I checked the changelog after rel 2.1.0 and we can merge this right away. If ok with you, merge this PR and create another one for the pure renames (with BC classes like here). @romaninsh is slow, we can merge all renames today today. |
Good. Moving on to next task now ... |
Split of #196
Part I - Refactoring of Debug proxy connections