Fix numeric compare affinity for SQLite #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
changed the title
mvorisek
changed the title
mvorisek
force-pushed
the
sqlite_float_bind
branch
10 times, most recently
from
f3bc2d8
to
c7b3b9d
Compare
mvorisek
force-pushed
the
sqlite_float_bind
branch
11 times, most recently
from
5c18e4b
to
b5d0903
Compare
mvorisek
force-pushed
the
sqlite_float_bind
branch
3 times, most recently
from
5910acb
to
2b639aa
Compare
mvorisek
force-pushed
the
sqlite_float_bind
branch
from
2b639aa
to
dcad20f
Compare
mvorisek
force-pushed
the
sqlite_float_bind
branch
8 times, most recently
from
699adcf
to
dbcd00a
Compare
mvorisek
force-pushed
the
sqlite_float_bind
branch
7 times, most recently
from
56a4173
to
3a9a0f1
Compare
mvorisek
force-pushed
the
sqlite_float_bind
branch
from
3a9a0f1
to
ba3c975
Compare
mvorisek
force-pushed
the
sqlite_float_bind
branch
3 times, most recently
from
c666ad2
to
6bd51b7
Compare
mvorisek
force-pushed
the
sqlite_float_bind
branch
from
6bd51b7
to
2e8d7ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #950
in theory, the fix should be done on whole SQL AST, but such approach requires AST parser, so for simplicity, the fix is done on comparison expressions created using
Query::where()method only