Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix long string param support for Oracle #974

Merged
merged 2 commits into from
Mar 13, 2022
Merged

Fix long string param support for Oracle #974

merged 2 commits into from
Mar 13, 2022

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Mar 13, 2022

read needs php/php-src#8018 for pdo_oci driver, oci8 driver is working

tested /w large value with size of 15 MiB, both text and blob DBAL types (~150 MB memory needed for Sqlite/Mysql, ~500 MB for Oracle and test took over 3 minutes to finish (vs. 1.5 second on Mysql))

@@ -77,7 +77,7 @@ jobs:
name: Unit
runs-on: ubuntu-latest
container:
image: ghcr.io/mvorisek/image-php:${{ matrix.php }}
image: ghcr.io/mvorisek/image-php:${{ matrix.php }}-debian
Copy link
Member Author

@mvorisek mvorisek Mar 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alpine support for newer pdo_oci is broken, see mlocati/docker-php-extension-installer#523

@mvorisek mvorisek force-pushed the oci_long_clob branch 4 times, most recently from df77822 to 6384652 Compare March 13, 2022 00:59
@mvorisek mvorisek marked this pull request as ready for review March 13, 2022 01:08
@mvorisek mvorisek changed the title Fix long CLOB param support for Oracle Fix long string param support for Oracle Mar 13, 2022
@mvorisek mvorisek merged commit 0897e0f into develop Mar 13, 2022
@mvorisek mvorisek deleted the oci_long_clob branch March 13, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant