Connection DSN can omit password #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
reviewed
Mar 2, 2022
| @@ -52,7 +52,7 @@ public static function connect($dsn, string $user = null, string $password = nul | |||
| case 'pdo_sqlsrv': | |||
| case 'pdo_oci': | |||
| case 'oci8': | |||
| $persistence = new Persistence\Sql($dsn, $dsn['user'], $dsn['password'], $args); | |||
| $persistence = new Persistence\Sql($dsn, $dsn['user'] ?? null, $dsn['password'] ?? null, $args); | |||
There was a problem hiding this comment.
connection string with empty password and in such case password is not set in dsn array
why $dsn['user'] ?? null then?
There was a problem hiding this comment.
also, why not to use http://username:@example.com as DSN for empty password?
There was a problem hiding this comment.
http://username:@ also don't set password key in dsn array and using ?? null to avoid exception in case password (or user) keys are not set in dsn array.
Maybe we need to do this validation in Connection class instead and always pass user and password keys even if they are null (not set).
|
PR LGTM, especially for sqlite DSN |
mvorisek
changed the title
mvorisek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can have connection string with empty password and in such case password is not set in dsn array.
This should fix that.
For example