Deduplicate model properties and Field/Join from entity #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
stricter_model_vs_entity
branch
from
baf5c58
to
4ba849c
Compare
This was referenced Nov 6, 2021
mvorisek
force-pushed
the
stricter_model_vs_entity
branch
4 times, most recently
from
6edde23
to
aeaf907
Compare
mvorisek
force-pushed
the
stricter_model_vs_entity
branch
8 times, most recently
from
5da6d19
to
6c98cf4
Compare
mvorisek
force-pushed
the
stricter_model_vs_entity
branch
5 times, most recently
from
4aae31e
to
d35b8d0
Compare
mvorisek
force-pushed
the
stricter_model_vs_entity
branch
from
9f185d5
to
6943787
Compare
mvorisek
force-pushed
the
stricter_model_vs_entity
branch
from
dc7f6d8
to
a38bd52
Compare
Merged
mvorisek
commented
Nov 10, 2021
| { | ||
| $value = ($value === null /* why not func_num_args() === 1 */ ? $this->get() : $this->normalize($value)); |
There was a problem hiding this comment.
FYI called in typecast too, no need to call twice...
mvorisek
force-pushed
the
stricter_model_vs_entity
branch
from
8180871
to
92694db
Compare
mvorisek
force-pushed
the
stricter_model_vs_entity
branch
from
b367fe8
to
b155701
Compare
DarkSide666
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BC break
Fieldis no longer bound to an entity, thus methods likeField::get,Field::setrequires entity provided as the 1st argument like$field->get($entity)BC/magic mapping for model properties and methods on entity is provided