Fix field typecast and drop Boolean field class #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
fix_null_type_norm
branch
from
52cd185
to
31b647c
Compare
mvorisek
force-pushed
the
fix_null_type_norm
branch
3 times, most recently
from
28e97a5
to
276f116
Compare
mvorisek
changed the title
mvorisek
force-pushed
the
fix_null_type_norm
branch
from
276f116
to
7bfad93
Compare
mvorisek
changed the title
mvorisek
force-pushed
the
fix_null_type_norm
branch
from
7bfad93
to
1dd4d38
Compare
mvorisek
force-pushed
the
fix_null_type_norm
branch
from
1dd4d38
to
7388b60
Compare
mvorisek
force-pushed
the
fix_null_type_norm
branch
from
334f233
to
ae1e229
Compare
mvorisek
force-pushed
the
fix_null_type_norm
branch
from
e5ab1f9
to
3e8e62e
Compare
mvorisek
changed the title
mvorisek
force-pushed
the
fix_null_type_norm
branch
4 times, most recently
from
5f2d4ef
to
fedfe4e
Compare
mvorisek
force-pushed
the
fix_null_type_norm
branch
from
fedfe4e
to
eb778d9
Compare
mvorisek
force-pushed
the
fix_null_type_norm
branch
9 times, most recently
from
0cf2890
to
a8c2f4f
Compare
mvorisek
force-pushed
the
fix_null_type_norm
branch
from
a8c2f4f
to
ff5d1da
Compare
mvorisek
force-pushed
the
fix_null_type_norm
branch
2 times, most recently
from
92b7b12
to
bb2302a
Compare
mvorisek
force-pushed
the
fix_null_type_norm
branch
from
bb8da62
to
42840ee
Compare
This was referenced Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes several bugs and always invoke DBAL typecast on non-generic/non-standard DBAL types.
Fixes several bugs like value of different type than
stringwas casted tonullwhich was wrong for types liketext. There should be minimal hardcoded type specific handling.BC break:
We also drop
Booleanfield class as it provided non-standard enum behaviour which should be provided by a custom DBAL type if really needed.