Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "money" type to "atk4_money" type #895

Merged
merged 8 commits into from
Oct 1, 2021
Merged

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Oct 1, 2021

  • DBAL types are global and by including this library within composer generic money type should not be added to other projects.
    To keep this type we rename it to atk4_money. This type represents basic float type with rounding to 4 decimal places.

  • We also drop password type as it does not provide any security. Password securtiy should be implemented using string type on higher app level.

  • newly, when no Field::type is set, the value is normalized using string type

  • Atk4\Schema\PhpunitTestCase class renamed to Atk4\Data\Schema\TestCase

  • Atk4\Schema\Migration class renamed to Atk4\Data\Schema\Migration

  • also adjust for renamed Hintable package name

@mvorisek mvorisek force-pushed the drop_cust_types branch 3 times, most recently from 7b8e737 to 65c5ecf Compare October 1, 2021 01:18
@mvorisek mvorisek marked this pull request as ready for review October 1, 2021 01:22
@mvorisek mvorisek added the RTM label Oct 1, 2021
@mvorisek mvorisek force-pushed the drop_cust_types branch 5 times, most recently from b6ded82 to a0651ef Compare October 1, 2021 13:39
@mvorisek mvorisek merged commit b06c578 into develop Oct 1, 2021
@mvorisek mvorisek deleted the drop_cust_types branch October 1, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants