Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix title field name guessing #835

Merged
merged 4 commits into from
Mar 2, 2021
Merged

Fix title field name guessing #835

merged 4 commits into from
Mar 2, 2021

Conversation

mvorisek
Copy link
Member

for atk4/ui#1595

guessing is always a compromise, but if id_field is prefixed, removing 'id' should be ok as a fallback

@mvorisek mvorisek changed the title Fix title field name guess Fix title field name guessing Feb 26, 2021
@mvorisek mvorisek mentioned this pull request Mar 2, 2021
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DarkSide666 DarkSide666 merged commit 10b7ab1 into develop Mar 2, 2021
@DarkSide666 DarkSide666 deleted the better_add_title_name branch March 2, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants