Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable MSSQL testing #754

Merged
merged 4 commits into from
Jan 25, 2021
Merged

Reenable MSSQL testing #754

merged 4 commits into from
Jan 25, 2021

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Oct 19, 2020 •
edited
Loading

merge after doctrine/dbal#4360

DarkSide666
DarkSide666 approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine if it works correct after DBAL PR merge

@mvorisek mvorisek marked this pull request as ready for review October 20, 2020 11:23
@mvorisek mvorisek force-pushed the reenable_mssql_once_dbal_fixed branch from 0cc1c3a to 070276d Compare October 20, 2020 11:23
@mvorisek mvorisek added the RTM label Oct 20, 2020
@mvorisek mvorisek force-pushed the reenable_mssql_once_dbal_fixed branch from 070276d to 2a54958 Compare October 20, 2020 11:24
@mvorisek mvorisek force-pushed the reenable_mssql_once_dbal_fixed branch from 2a54958 to 1cd3695 Compare January 25, 2021 22:37
@mvorisek mvorisek changed the title Reenable MSSQL testing once DBAL is fixed Reenable MSSQL testing Jan 25, 2021
@mvorisek mvorisek merged commit 2ddd5e2 into develop Jan 25, 2021
@mvorisek mvorisek deleted the reenable_mssql_once_dbal_fixed branch January 25, 2021 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkSide666 DarkSide666 DarkSide666 approved these changes

@georgehristov georgehristov Awaiting requested review from georgehristov

Assignees
No one assigned
Labels
RTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvorisek @DarkSide666