Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs about dirty fields and after save hook #1131

Merged
merged 4 commits into from
Sep 14, 2023

Conversation

PhilippGrashoff
Copy link
Contributor

@PhilippGrashoff PhilippGrashoff commented Sep 14, 2023

related with #1130

The old PHPDoc implied that $dirty data was available in Model::HOOK_AFTER_SAVE spot. This is not the case.

src/Model.php Outdated Show resolved Hide resolved
@mvorisek mvorisek changed the title fix Model::dirty PHPDoc about its availability in after save hook Update docs about dirty fields and after update hook Sep 14, 2023
@mvorisek mvorisek changed the title Update docs about dirty fields and after update hook Update docs about dirty fields and after save hook Sep 14, 2023
@mvorisek mvorisek merged commit b99fdc1 into atk4:develop Sep 14, 2023
15 checks passed
@PhilippGrashoff PhilippGrashoff deleted the fix_model_dirty_description branch September 16, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants