Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Model::isset/getPersistence() calls on model only #1088

Merged
merged 5 commits into from
Feb 10, 2023

Conversation

mvorisek
Copy link
Member

Currently Model is tightly coupled with one persistence.

persistence getters on entity are not wanted and $this->_persistence in $entity->getPersistence() was fetched using __get

@mvorisek mvorisek marked this pull request as ready for review January 24, 2023 15:09
@mvorisek mvorisek force-pushed the no_entity_persistence_methods branch from 0be6ba1 to ac9dcd6 Compare January 24, 2023 15:18
@mvorisek mvorisek force-pushed the no_entity_persistence_methods branch from d4ec429 to e3079d3 Compare January 24, 2023 15:24
Copy link
Contributor

@mkrecek234 mkrecek234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvorisek mvorisek merged commit dfa5de5 into develop Feb 10, 2023
@mvorisek mvorisek deleted the no_entity_persistence_methods branch February 10, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants