Test FK violation during FK create

src/Persistence/Sql/Sqlite/SchemaManagerTrait.php

@@ -4,7 +4,7 @@
 
 namespace Atk4\Data\Persistence\Sql\Sqlite;
 
-use Atk4\Data\Persistence\Sql\Exception;
+use Doctrine\DBAL\Exception as DbalException;
 use Doctrine\DBAL\Schema\Identifier;
 use Doctrine\DBAL\Schema\Table;
 use Doctrine\DBAL\Schema\TableDiff;
@@ -25,8 +25,7 @@ public function alterTable(TableDiff $tableDiff): void
 
             $rows = $this->_conn->executeQuery('PRAGMA foreign_key_check')->fetchAllAssociative();
             if (count($rows) > 0) {
-                throw (new Exception('Foreign key constraints are violated'))
-                    ->addMoreInfo('data', $rows);
+                throw new DbalException('Foreign key constraints are violated');
             }
         }
     }

src/Schema/TestSqlPersistence.php

@@ -37,6 +37,11 @@ public function getConnection(): Persistence\Sql\Connection
                     null ?? new class() implements SQLLogger {
                         public function startQuery($sql, array $params = null, array $types = null): void
                         {
+                            // fix https://github.com/doctrine/dbal/issues/5525
+                            if ($params !== null && $params !== [] && array_is_list($params)) {
+                                $params = array_combine(range(1, count($params)), $params);
+                            }
+
                             $test = TestCase::getTestFromBacktrace();
                             \Closure::bind(fn () => $test->logQuery($sql, $params ?? [], $types ?? []), null, TestCase::class)();
                         }

tests/Schema/MigratorFkTest.php

@@ -7,6 +7,7 @@
 use Atk4\Data\Exception;
 use Atk4\Data\Model;
 use Atk4\Data\Schema\TestCase;
+use Doctrine\DBAL\Exception as DbalException;
 use Doctrine\DBAL\Exception\ForeignKeyConstraintViolationException;
 use Doctrine\DBAL\Schema\ForeignKeyConstraint;
 
@@ -76,4 +77,22 @@ public function testForeignKeyViolation(): void
             throw $e;
         }
     }
+
+    public function testForeignKeyViolationDuringSetup(): void
+    {
+        $country = new Model($this->db, ['table' => 'country']);
+        $country->addField('name');
+
+        $client = new Model($this->db, ['table' => 'client']);
+        $client->addField('name');
+        $client->hasOne('country_id', ['model' => $country]);
+
+        $this->createMigrator($client)->create();
+        $this->createMigrator($country)->create();
+
+        $client->insert(['name' => 'Leos', 'country_id' => 10]);
+
+        $this->expectException(DbalException::class);
+        $this->createMigrator()->createForeignKey($client->getReference('country_id'));
+    }
 }