Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"mandatory" null validation is not working #575

Closed
mvorisek opened this issue Apr 25, 2020 · 1 comment · Fixed by #561 or #899
Closed

"mandatory" null validation is not working #575

mvorisek opened this issue Apr 25, 2020 · 1 comment · Fixed by #561 or #899
Assignees

Comments

@mvorisek
Copy link
Member

mvorisek commented Apr 25, 2020

See

$m->set('c', null); // @TODO even "b"/mandatory field should fail!

b/mandatory field should throw when null is set like the c/required field there.

As confirmed by @DarkSide666, the set() method is expected to fully normalize/validate the field at the time of setting the value (ie. immediatelly as required does).

Considering this as a Major as this is core functionality and many developers may rely on that.

@mvorisek
Copy link
Member Author

Related with #576 , as the currently implementation does not even work as defined, fixing this issue will break the BC anyway, so it should be not fixed and full refactoring like analysed and proposed in #576 should be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants