Fix Scope::$shortName cannot be unset to null (#1156)

atk4 · Jan 27, 2024 · 9b2c14c · 9b2c14c
1 parent 2724005
commit 9b2c14c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/docs/advanced.md b/docs/advanced.md
@@ -365,7 +365,7 @@ class ControllerUniqueFields
     }
     use \Atk4\Core\TrackableTrait;
 
-    protected $fields = null;
+    protected ?array $fields = null;
 
     protected function init(): void
     {

diff --git a/src/Model/Scope.php b/src/Model/Scope.php
@@ -64,7 +64,7 @@ public function __clone()
         if ($this->issetOwner()) {
             $this->unsetOwner();
         }
-        $this->shortName = null; // @phpstan-ignore-line
+        // $this->shortName = null; // uncomment once https://github.com/php/php-src/issues/9389 is resolved
     }
 
     /**