Remove NameTrait from TrackableTrait #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
unimpl_name_trait_from_trackable_trait
branch
from
a60c240
to
07e3467
Compare
mvorisek
force-pushed
the
unimpl_name_trait_from_trackable_trait
branch
from
07e3467
to
72b3cff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #342
and atk4/data,
obj->nameis set only if owner & child is trackable, but in atk4/data, Model is NOT trackable, thusnamewas never set in Field, Reference, ... but was declaredissues like atk4/data#942 will be thus always detected by phpstan