Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't log dsql expressions #22

Merged
merged 1 commit into from
Oct 22, 2018
Merged

don't log dsql expressions #22

merged 1 commit into from
Oct 22, 2018

Conversation

DarkSide666
Copy link
Member

romaninsh
romaninsh approved these changes Oct 22, 2018
View reviewed changes
Copy link
Member

@romaninsh romaninsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend to skip all objects entirely as we won't be able to display them in the audit log anyways. Perhaps with an option for user to extend and add methods to connect objects into scalar values, but this should do for now.

@DarkSide666
Copy link
Member Author

Well, DateTime object is quite ok to have there. Basically any object which can be cast to string somehow should be ok.

@DarkSide666 DarkSide666 merged commit c3593ee into develop Oct 22, 2018
@DarkSide666 DarkSide666 deleted the feature/dont-log-expressions branch October 22, 2018 22:14
@DarkSide666 DarkSide666 mentioned this pull request Oct 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romaninsh romaninsh romaninsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarkSide666 @romaninsh