-
-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(blocks): first block-writing features (WIP) using event listeners #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tangjeff0
commented
Jun 19, 2020
- fix block toggle for block- and node-pages
- dragging bullet point. positioning of bullet needs offset
- click to edit textarea
- real datascript transactions
- fix block toggle for block- and node-pages - dragging bullet point. positioning of bullet needs offset - click to edit textarea - real datascript transactions
feat(blocks): better block dragging and editing
…rent... feat(blocks): faster styles for dragging bullet
merging in WIP per #161 |
estellerostan
pushed a commit
to estellerostan/athens
that referenced
this pull request
Jun 20, 2020
athensresearch#158) * feat(blocks): writing to blocks, event listeners - fix block toggle for block- and node-pages - dragging bullet point. positioning of bullet needs offset - click to edit textarea - real datascript transactions * prep feature branch for Stuart * feat(blocks): better bullet dragging * feat(blocks): better textarea styling * feat(blocks): redesign drop area indicator * chore: fix lint issues * move around code * 1/2 of drop bullet done. loses original parent, but can't find new parent... feat(blocks): faster styles for dragging bullet * use a working block ref * CI scripts Co-authored-by: shanberg <98312+shanberg@users.noreply.github.com>
korlaism
pushed a commit
to korlaism/athens
that referenced
this pull request
Jul 19, 2021
athensresearch#158) * feat(blocks): writing to blocks, event listeners - fix block toggle for block- and node-pages - dragging bullet point. positioning of bullet needs offset - click to edit textarea - real datascript transactions * prep feature branch for Stuart * feat(blocks): better bullet dragging * feat(blocks): better textarea styling * feat(blocks): redesign drop area indicator * chore: fix lint issues * move around code * 1/2 of drop bullet done. loses original parent, but can't find new parent... feat(blocks): faster styles for dragging bullet * use a working block ref * CI scripts Co-authored-by: shanberg <98312+shanberg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.