chore: Add with-attributes to clean up attributes #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will add :on-keypress {:ESC (fn [event] )} later
tangjeff0
approved these changes
May 31, 2020
jeroenvandijk
changed the title
korlaism
pushed a commit
to korlaism/athens
that referenced
this pull request
Jul 19, 2021
* Add with-attributes to clean up attributes
Will add :on-keypress {:ESC (fn [event] )} later
* No js/ vars in cljc namespaces
* Fix clj-kondo warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tangjeff0 What do you think about this? It should make combining styles, classes and later other things like event listeners much cleaner (see #111)
I'm thinking about adding specialized key listeners in the same like
:on-keypress {:ESC (fn [event] )}later. This will help implement #64