Improve error handling in Go bindings #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrettig
force-pushed
the
go-error-handling
branch
from
d7dc29e
to
0dbb981
Compare
poszu
requested changes
Oct 23, 2024
Don't print error locally; return a more useful error
poszu
reviewed
Oct 24, 2024
poszu
approved these changes
Oct 24, 2024
Don't expose unused error codes
poszu
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring in the rest of the ATHCON errors. Allow athena errors in Go to wrap underlying Go errors.
These are quality of life improvements that make the go-sm integration work easier.