Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove custom implementations of memcpy and memset #150

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

poszu
Copy link
Collaborator

@poszu poszu commented Oct 14, 2024

Fixes #149
They are already present in the stdlib, not sure why they were added in the first place.

They are already present in the stdlib, not sure why they were added in
the first place.
@poszu
Copy link
Collaborator Author

poszu commented Oct 14, 2024

@lrettig Your hasher-test produces the correct hash each time with this fix, check out this branch: https://github.com/athenavm/athena/tree/hasher-test-fixed

@lrettig lrettig merged commit 0f6c1f0 into main Oct 14, 2024
10 checks passed
@lrettig lrettig deleted the fix/remove-custom-memcpy-memset-impls branch October 14, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blake3 output not deterministic in guest
3 participants