Consolidate method and args into a single opaque payload #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing from guest VM WIP
Remove method from low-level call host call (method selector moved into input entirely) call SDK now constructs the input correctly using the method selector. Update the recursive call test accordingly. Allow the use of a default selector.
And rebuild tests
Clean up tests Add tests for method selector Still working on getting tests to pass
For now working around #149
To work around cargo audit issue
poszu
requested changes
Oct 15, 2024
Tests passing
to use SCALE with MethodSelector and ExecutionPayload
Switch to using gossamer scale library, much simpler
Merged
poszu
reviewed
Oct 16, 2024
ffi/athcon/bindings/rust/athcon-client/tests/integration_tests.rs
Outdated
Show resolved
Hide resolved
Make some function names more explicit Remove unnecessary encode/decode fns
poszu
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #146, also fixes #113