Update C API to use uint64_t instead of uint256be where it makes sense #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrettig
reviewed
Oct 11, 2024
What do you mean? I updated athcon.h and both Rust sides of the FFI in this PR (and Go host side too). |
lrettig
approved these changes
Oct 11, 2024
I must've only been seeing one commit, oops... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #140.
Updated:
get_balance()to returnuint64_tathcon_message::valuetouint64_tas it represents coins and is converted to uint64_t internally anywaysathcon_tx_context::tx_gas_priceas it is converted touint64_tinternally