Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deploy host function #108

Merged
merged 7 commits into from
Oct 2, 2024
Merged

deploy host function #108

merged 7 commits into from
Oct 2, 2024

Conversation

poszu
Copy link
Collaborator

@poszu poszu commented Sep 13, 2024 •
edited by lrettig
Loading

Closes #76

lrettig
lrettig requested changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@lrettig lrettig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nits but overall lgtm!

examples/wallet/script/src/bin/execute.rs Outdated Show resolved Hide resolved
examples/wallet/script/src/bin/execute.rs Outdated Show resolved Hide resolved
examples/wallet/script/src/bin/execute.rs Outdated Show resolved Hide resolved
interface/src/lib.rs Outdated Show resolved Hide resolved
interface/src/lib.rs Outdated Show resolved Hide resolved
vm/entrypoint/src/syscalls/host.rs Outdated Show resolved Hide resolved
examples/wallet/script/src/bin/execute.rs Outdated Show resolved Hide resolved
ffi/athcon/include/athcon/athcon.h Outdated Show resolved Hide resolved
poszu and others added 3 commits September 16, 2024 13:25
@poszu @lrettig
Apply suggestions from code review
4bf4ba4 
Co-authored-by: Lane Rettig <lanerettig@gmail.com>
@poszu @lrettig
Apply suggestions from code review
fd624f1 
Co-authored-by: Lane Rettig <lanerettig@gmail.com>
@poszu
Merge branch 'vmsdk-poszu-spawn-returns-address' into feature/host-de…
be01252 
…ploy
Base automatically changed from vmsdk-poszu-spawn-returns-address to main September 27, 2024 07:20
@poszu poszu marked this pull request as ready for review September 30, 2024 09:10
@poszu poszu requested a review from lrettig September 30, 2024 09:10
@poszu poszu merged commit 98c3234 into main Oct 2, 2024
8 checks passed
@poszu poszu deleted the feature/host-deploy branch October 2, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrettig lrettig lrettig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement deploy host function
2 participants
@poszu @lrettig